lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] [SCSI] mvsas: fix multiple shift issues
Date
The main issue is that bit(n) is defined as:

(u32)1 << n

Thus bit(n) with n >= 32 will produce 0 or 1, depending on the
architecture. This is also undefined behavior in C.

The OR with sata_reg_set (u64) then doesn't work because bit()
does a 32-bit shift, which should have been a 64-bit shift:

if (i >= 32) {
mvi->sata_reg_set |= bit(i);
...
}

The other two patches fix similar oversized shift issues.

Xi Wang (3):
[SCSI] mvsas: fix shift in mvs_94xx_assign_reg_set()
[SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()
[SCSI] mvsas: fix shift in mv_ffc64()

drivers/scsi/mvsas/mv_94xx.c | 8 +++++---
drivers/scsi/mvsas/mv_94xx.h | 14 ++------------
drivers/scsi/mvsas/mv_sas.h | 2 +-
3 files changed, 8 insertions(+), 16 deletions(-)

--
1.7.10.4



\
 
 \ /
  Last update: 2012-11-05 21:41    [W:0.130 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site