lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch,v2 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node
Date
Bart Van Assche <bvanassche@acm.org> writes:

> On 11/02/12 22:45, Jeff Moyer wrote:
>> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
>> index 2936b44..4db6973 100644
>> --- a/drivers/scsi/scsi.c
>> +++ b/drivers/scsi/scsi.c
>> @@ -173,16 +173,20 @@ static DEFINE_MUTEX(host_cmd_pool_mutex);
>> * NULL on failure
>> */
>> static struct scsi_cmnd *
>> -scsi_pool_alloc_command(struct scsi_host_cmd_pool *pool, gfp_t gfp_mask)
>> +scsi_pool_alloc_command(struct scsi_host_cmd_pool *pool, gfp_t gfp_mask,
>> + int node)
>> {
>> struct scsi_cmnd *cmd;
>>
>> - cmd = kmem_cache_zalloc(pool->cmd_slab, gfp_mask | pool->gfp_mask);
>> + cmd = kmem_cache_alloc_node(pool->cmd_slab,
>> + gfp_mask | pool->gfp_mask | __GFP_ZERO,
>> + node);
>> if (!cmd)
>> return NULL;
>>
>> - cmd->sense_buffer = kmem_cache_alloc(pool->sense_slab,
>> - gfp_mask | pool->gfp_mask);
>> + cmd->sense_buffer = kmem_cache_alloc_node(pool->sense_slab,
>> + gfp_mask | pool->gfp_mask | __GFP_ZERO,
>> + node);
>
> It's not clear to me why __GFP_ZERO is added to the allocation flags ?

Hmm, seems I thought this was another case of kmem_cache_zalloc. I'll
fix it up.

Cheers,
Jeff


\
 
 \ /
  Last update: 2012-11-05 20:21    [W:1.218 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site