lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[RFC] cgroup: deprecate clone_children
clone_children makes cgroup invoke ->post_clone() callback if it
exists and sets CGRP_CLONE_CHILDREN. ->post_clone(), while being
named generically, is only supposed to copy configuration from its
parent.

This is an entirely convenience feature which is only used by cpuset
to alter its configuration propagation. As the mount option and
cgroupfs knobs are cgroup-wide and different controllers differ in
their configuration propagations, it's awkward to use for multiple
controllers especially if they're co-mounted. At this point, we can't
use this flag for any other controller anyway as it would implicitly
change the behavior.

As this is unnecessary feature with very limited use and awkward in
co-mounted use cases, let's try to deprecate it. Whine on the mount
option and accesses to cgroupfs knobs.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Glauber Costa <glommer@parallels.com>
Cc: Peter Zijlstra <peterz@infradead.org>
---
Glauber, I think this is more befitting change for .post_clone(). If
people aren't depending on this, I'd much prefer to just remove it.

Thanks.

kernel/cgroup.c | 8 ++++++++
1 file changed, 8 insertions(+)

--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1162,6 +1162,8 @@ static int parse_cgroupfs_options(char *
continue;
}
if (!strcmp(token, "clone_children")) {
+ pr_warning("cgroup: mount option clone_children is deprecated (pid=%d comm=%s)\n",
+ task_tgid_nr(current), current->comm);
opts->clone_children = true;
continue;
}
@@ -3837,6 +3839,9 @@ fail:
static u64 cgroup_clone_children_read(struct cgroup *cgrp,
struct cftype *cft)
{
+ printk_ratelimited(KERN_WARNING "cgroup: clone_children is deprecated (pid=%d comm=%s)\n",
+ task_tgid_nr(current), current->comm);
+
return clone_children(cgrp);
}

@@ -3844,6 +3849,9 @@ static int cgroup_clone_children_write(s
struct cftype *cft,
u64 val)
{
+ printk_ratelimited(KERN_WARNING "cgroup: clone_children is deprecated (pid=%d comm=%s)\n",
+ task_tgid_nr(current), current->comm);
+
if (val)
set_bit(CGRP_CLONE_CHILDREN, &cgrp->flags);
else

\
 
 \ /
  Last update: 2012-11-05 19:41    [W:0.136 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site