Messages in this thread | | | Date | Mon, 5 Nov 2012 11:04:39 +0530 | Subject | Re: [PATCH 1/1] staging: usbip: remove an unnecessary lock in usbip_event_happened. The variable "happened" is local. So I think there is no need to lock here. | From | Prashant Shah <> |
| |
Hi,
> int happened = 0; > > - spin_lock(&ud->lock); > if (ud->event != 0) > happened = 1; > - spin_unlock(&ud->lock); > > return happened;
I am guessing locking was intended to protect ud->event along with happened so that (checking the value of ud->event and setting value of happened) was atomic.
return ud->event != 0 ? 1 : 0;
Regards.
| |