Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [patch,v2 01/10] scsi: add scsi_host_alloc_node | Date | Mon, 05 Nov 2012 09:06:53 -0500 |
| |
Bart Van Assche <bvanassche@acm.org> writes:
> On 11/02/12 22:45, Jeff Moyer wrote: >> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c >> index 593085a..7d7ad8b 100644 >> --- a/drivers/scsi/hosts.c >> +++ b/drivers/scsi/hosts.c >> @@ -336,16 +336,25 @@ static struct device_type scsi_host_type = { >> **/ >> struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) >> { >> + return scsi_host_alloc_node(sht, privsize, -1); > > Using NUMA_NO_NODE here might improve readability.
Agreed, I'll fix that.
>> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h >> index 4908480..a1b5c8e 100644 >> --- a/include/scsi/scsi_host.h >> +++ b/include/scsi/scsi_host.h >> @@ -733,6 +733,12 @@ struct Scsi_Host { >> struct device *dma_dev; >> >> /* >> + * Numa node this device is closest to, used for allocating >> + * data structures locally. >> + */ >> + int numa_node; > > Have you considered using #ifdef CONFIG_NUMA / #endif here ? I've > noticed that all other numa_node members in structures under include/ > have this.
That was an oversight, thanks for pointing it out. I'll fix it up.
Cheers, Jeff
| |