Messages in this thread | | | Date | Mon, 5 Nov 2012 14:28:52 +0100 | Subject | Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path | From | Benjamin Tissoires <> |
| |
Hi Henrik,
On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg <rydberg@euromail.se> wrote: > Hi Benjamin, > >> >> This patch factorizes the hid set_feature command by using >> >> hid_device->hid_output_raw_report instead of direclty relying on >> >> usbhid. This makes the driver usb independant. >> >> >> >> However I still can't remove the 2 usb related headers because the >> >> function mt_resume has a specific patch for usb devices. >> >> >> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> >> >> --- >> >> drivers/hid/hid-multitouch.c | 63 ++++++++++++++++++++++++++------------------ >> >> 1 file changed, 37 insertions(+), 26 deletions(-) >> > >> > In my drawer, I have a patchset that aims to remove all usbhid >> > dependence, from all the drivers. Perhaps the attached patch is >> > something to consider here? >> >> yep, removing usbhid dependencies is a good thing. >> See my review below :) > > I have a tentative patch taking your comments into account, and it is > likely that we want to go that way. However, as to not hold up your > patchset, perhaps we could do without it for now. > > Regarding the hardwired usbhid dependency, I think the solution is to > move that code to usbhid itself. > > Thanks, > Henrik
| |