lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] spi / ACPI: add ACPI enumeration support
On Mon, Nov 05, 2012 at 01:03:22PM +0200, Mika Westerberg wrote:
> On Mon, Nov 05, 2012 at 11:54:55AM +0100, Mark Brown wrote:
> > On Sat, Nov 03, 2012 at 09:46:32AM +0200, Mika Westerberg wrote:

> > > + strlcpy(spi->modalias, acpi_device_hid(adev), sizeof(spi->modalias));
> > > + if (info.gsi >= 0)
> > > + spi->irq = acpi_register_gsi(&adev->dev, info.gsi,
> > > + info.triggering, info.polarity);
> > > + request_module(spi->modalias);

> > request_module()? Why?

> The DT code does the same. I have no idea why it is there, really :-)

> I can remove it in the next version if you think it is not needed.

Well, if you can't identify what it does...
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-11-05 13:01    [W:0.085 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site