Messages in this thread | | | Date | Sun, 4 Nov 2012 14:20:00 +0100 | Subject | Re: [v2 PATCH 1/2] Add new uio device for dynamic memory allocation | From | Geert Uytterhoeven <> |
| |
On Tue, Sep 25, 2012 at 8:09 AM, Damian Hobson-Garcia <dhobsong@igel.co.jp> wrote: > are holding the device file open, the address returned to userspace is > DMA_ERROR_CODE.
Only a small subset of the architectures (arm/ia64/microblaze/openrisc/powerpc/sparc/x86) seem to define DMA_ERROR_CODE, causing everywhere else:
drivers/uio/uio_dmem_genirq.c: In function ‘uio_dmem_genirq_release’: drivers/uio/uio_dmem_genirq.c:95: error: ‘DMA_ERROR_CODE’ undeclared (first use in this function) drivers/uio/uio_dmem_genirq.c:95: error: (Each undeclared identifier is reported only once drivers/uio/uio_dmem_genirq.c:95: error: for each function it appears in.) drivers/uio/uio_dmem_genirq.c: In function ‘uio_dmem_genirq_probe’: drivers/uio/uio_dmem_genirq.c:238: error: ‘DMA_ERROR_CODE’ undeclared (first use in this function) make[1]: *** [drivers/uio/uio_dmem_genirq.o] Error 1 make: *** [drivers/uio/] Error 2
(e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/7462173/)
Furthermore, none of them define it in <uapi/...>, so DMA_ERROR_CODE is not part of the userspace API (yet), while it is architecture-specific (some use 0, others ~0).
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |