Messages in this thread | | | Date | Sun, 04 Nov 2012 12:30:13 -0500 (EST) | Subject | Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning | From | David Miller <> |
| |
From: Lee Jones <lee.jones@linaro.org> Date: Sun, 4 Nov 2012 11:53:32 +0100
> On Sun, 04 Nov 2012, Paul Bolle wrote: > >> On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: >> > On Sat, 03 Nov 2012, Paul Bolle wrote: >> > > On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: >> > > > This patch fixes: >> > > > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: >> > > > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable] >> > > >> > > Did you have CONFIG_NETDEVICES not set in this build? >> > >> > Ah yes, I see it. The function went down further than I thought >> > it did. So the real fix is to ensure 's' is defined inside of >> > some ifdef CONFIG_NETDEVICES guards. >> >> What puzzles me is that we only find these "#ifdef CONFIG_NETDEVICES" >> guards in this file and not in isdn_net.c, were all the ioctl commands >> guarded that way seem to be calling into. On first glance that doesn't >> make much sense. >> >> (Actually the idea of having ISDN without NETDEVICES is a bit puzzling >> too. But there are too many parts of the isdn subsystem that I'm >> unfamiliar with to say whether that can make sense.) > > I'm in the same position as you Paul. I just noticed the warning so > fixed it following the current way of doing things. Any, more > substantial changes requiring greater knowledge of the subsystem > would have to be done by someone else.
I think the most appropriate thing to do is make CONFIG_ISDN depend upon CONFIG_NETDEVICES in the Kconfig file.
| |