lkml.org 
[lkml]   [2012]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 6/6] f2fs: move error condition for mkdir at proper place
Date
From: Namjae Jeon <namjae.jeon@samsung.com>

In function f2fs_mkdir, err is being initialized without even checking
if there was any error in new inode creation. So, instead check the
inode error and make use of error/return condition.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
fs/f2fs/namei.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 63efd77..2d720ca 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -287,9 +287,8 @@ static int f2fs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
int err;

inode = f2fs_new_inode(dir, S_IFDIR | mode);
- err = PTR_ERR(inode);
if (IS_ERR(inode))
- return err;
+ return PTR_ERR(inode);

inode->i_op = &f2fs_dir_inode_operations;
inode->i_fop = &f2fs_dir_operations;
--
1.7.9.5


\
 
 \ /
  Last update: 2012-12-01 03:41    [W:0.045 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site