lkml.org 
[lkml]   [2012]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Avoid dead lock of console related locks in panic case
On Fri, 30 Nov 2012 22:59:13 +0000
Seiji Aguchi <seiji.aguchi@hds.com> wrote:

> >
> > Let's step back a bit. Please identify with great specificity the code sites which are stopping other CPUs before taking locks which
> > those other CPUs might have been holding.
> >
> > Then let's see what we can do to fix up the callers, instead of trying to tidy up after they have made this mess.
>
> OK.
> I will update my patch without adding complexity.
> The logic will be as follows, if I understand your comment correctly.
>
> - take console related locks (logbuf_lock, console_sem)
> - stop other cpus
> - release those locks

That would be one way around the problem. It's still a bit messy,
because we'll have to take more and more locks in the future, as we
identify them.

What I actually meant was: can "this" CPU avoid stopping other CPUs so
early? If we stop the other CPUs when this CPU is ready to stop itself
then there will never be such deadlocks.



\
 
 \ /
  Last update: 2012-12-01 00:41    [W:0.065 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site