Messages in this thread | | | Date | Fri, 30 Nov 2012 11:51:41 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86, fpu: avoid FPU lazy restore after suspend |
| |
On 11/30/2012 11:41 AM, Linus Torvalds wrote: >> >> Hmm... from my point of view it would almost seem saner to do this on >> the way *up*... as part of CPU (re-)initialization. After all, the >> "nothing is currently running on this CPU" is part of the initial state >> of the CPU, regardless of if we have ever been online before or not. > > That works for me too, and has the similar advantage of being easier > to think about than "the cpu is actually still being used, and we're > playing tricks with the FPU state cache" approach. > > Regardless, much credit to Vincent (and presumably others on the > chromium team) for finding and debugging this. >
OK, how do you want to handle this, given that 3.7 is presumably imminent? We can apply Vincent's patch now, and then restructure it later, or we can go for the gold now, but replicating the testing Vincent has done will probably take well into next week.
-hpa
| |