Messages in this thread | | | Date | Fri, 30 Nov 2012 07:35:00 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH]realtek:r8169: Bugfix or workaround for missing extended GigaMAC registers settings |
| |
Wang YanQing <udknight@gmail.com> : [...] > After add some debug code, I found this NIC only accept ethernet > broadcast package, it can't filter out the package send to its > MAC address, but it works good for sending.So ifconfig show the > RX/TX status means it can receive ARP package.(It don't its MAC > address, so below)
Which kernel version is it ?
[...] > I haven't see any code to set GigaMAC registers in kernel when boot, > so I guess BIOS or NIC's circuit make it, but of course one miss
I'd appreciate to figure it out (and understand why I did not notice it when testing).
> the extended GigaMAC registers in this problem. The probe code can > get MAC address right, so MAC{0,4} must had been setted, but some > guys forget the extended GigaMAC registers. > > This patch fix it.
It is a good analysis job.
I'd rather see the GigaMAC registers written through a call to rtl_rar_set when the mac address is read in rtl_init_one instead of duplicating most of rtl_rar_set in a quite different place.
Hayes, can you specify if it would work or if it may mess the registers init sequence ordering ?
Thanks.
-- Ueimor
| |