Messages in this thread | | | Date | Fri, 30 Nov 2012 18:17:49 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 4/4 v8] AMD64 EDAC: Fix type usage in NB IDs and memory ranges |
| |
On Fri, Nov 30, 2012 at 04:44:20PM +0800, Daniel J Blueman wrote: > Use appropriate types for northbridge IDs and memory ranges. Mark immutable > data const and keep within compilation unit on related structures. Tested on > multi-socket server and multi-server, multi-socket NumaConnect setup. > > v7: Refactor patches grouping changes > v8: Drop unneeded change; use const and static where appropriate > > Signed-off-by: Daniel J Blueman <daniel@numascale-asia.com> > --- > arch/x86/include/asm/amd_nb.h | 2 +- > drivers/edac/amd64_edac.c | 26 +++++++++++++------------- > drivers/edac/amd64_edac.h | 6 +++--- > 3 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/arch/x86/include/asm/amd_nb.h b/arch/x86/include/asm/amd_nb.h > index 417eb24..d2e703b 100644 > --- a/arch/x86/include/asm/amd_nb.h > +++ b/arch/x86/include/asm/amd_nb.h > @@ -76,7 +76,7 @@ static inline bool amd_nb_has_feature(unsigned feature) > return ((amd_northbridges.flags & feature) == feature); > } > > -static inline struct amd_northbridge *node_to_amd_nb(int node) > +static inline struct amd_northbridge *node_to_amd_nb(u16 node)
I'm dropping this change from this patch because if we go with it, we'll have to change all callsites of node_to_amd_nb which would cause unnecessary churn.
So, I've applied the final patchset and uploaded a branch here:
git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git numascale
Please give it a run on both configurations and let me know if something is still amiss.
Thanks.
-- Regards/Gruss, Boris.
| |