Messages in this thread | | | Subject | Re: [PATCH 1/3] aerdrv: Trace Event for AER | From | Steven Rostedt <> | Date | Fri, 30 Nov 2012 08:53:51 -0500 |
| |
On Fri, 2012-11-30 at 14:42 +0100, Borislav Petkov wrote:
> So, it sounds to me like we should we move all RAS-specific tracepoints > to <trace/events/ras.h> and then in each usage site do:
Note, the CREATE_TRACE_POINTS must only be done in one location. Not every place. It creates the code that does the work to make the tracepoints show up in /debug/tracing/events/* as well as the callback code and other such things. If you define it in more than one .c file, then you will have linker issues due to the functions being created more than once.
> > #define CREATE_TRACE_POINTS > #include <trace/events/ras.h> > > Correct?
That's the default way to do things.
> > FWIW, it looks neat and clean to me that way.
Yep, that's why it's default ;-)
-- Steve
| |