Messages in this thread | | | Date | Fri, 30 Nov 2012 12:39:28 +0100 | From | Lars Marowsky-Bree <> | Subject | Re: [dm-devel] [PATCH 2/3] dm raid1: add interface to set resync speed |
| |
On 2012-11-22T14:27:52, Guangliang Zhao <gzhao@suse.com> wrote:
Hi Guangliang,
thanks for adding this. I think this approach is a good direction to take, just one feedback:
> Add ioctl to control resync speed, userspace tool > is dmsetup message, message format is: > dmsetup message $device 0 "set $speed" > e.g. > dmsetup message /dev/dm-2 "set 12345"
I think this should be "set-max-resync-rate" or something; "set" is very generic and not very extensible going forward, should the need arise.
Regards, Lars
-- Architect Storage/HA SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg) "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |