Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib | Date | Fri, 30 Nov 2012 11:30:21 +0000 |
| |
On Fri, 5 Oct 2012 14:20:55 +0200, Drasko DRASKOVIC <drasko.draskovic@gmail.com> wrote: > Hi all, > please find a patch that adds IRQ edge set-up mechanism to sysfs that > can be called from the kernel. > > This functionality can be very useful for embedded systems, as it > permits kernel to do GPIO set-up during boot stage. Configuration > which defines pins behavior is often kept in NVRAM, and during boot > stage these structures can be parsed and executed by the kernel, so > that when user processes already find all sysfs environment ready and > correctly set-up. > > While at the present it is possible to export GPIO pins to sysfs (and > correct direction / value), it is not possible to export IRQ > configuration as well, so this must be done in user space (most often > via command line). this patch implements missing functionality, so > that gpio_sysfs_set_edge() function can be called directly from the > kernel.
This really seems like the wrong place to be doing this. If the GPIO needs to be used with a particular configuration for an IRQ, then the device tree or platform data on non-dt should be given that information. I do not feel good about exporting anonymnous IRQ configuration to userspace.
| |