lkml.org 
[lkml]   [2012]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()
Date
Olof Johansson wrote:
>
> On Wed, Nov 28, 2012 at 8:16 AM, Doug Anderson <dianders@chromium.org>
> wrote:
> > Olof / Kukjin,
> >

[...]

> >>
> >> I really don't like splitting an if/else with an ifdef like this, it's
> fragile
> >> code and can be hard to follow.
> >
> > Agree.

Definitely, same here ;-)

> >> There's also a second build error with exynos_defconfig in the
> >> exynos5-dt.c board file due to a missing include. Teaches me to just
> apply
> >> patches without trying to build. :(
> >
> > In the tree I was testing against (the arm-soc/for-next branch at
> > 659b19ca3a77e2ac32fe84d95242653c75dd07c7) I see the include file in
> > the exynos5-dt.c file already. In my tree it was added by "2eae613b:
> > ARM: EXYNOS: Add MFC device tree support".
> >
> > Your patch applies cleanly on mine but I end up with:
> >
> > #include <linux/of_platform.h>
> > #include <linux/of_fdt.h>
> > #include <linux/serial_core.h>
> > #include <linux/io.h>
> > #include <linux/memblock.h>
> > #include <linux/of_fdt.h>
>
> Sigh, this is because people add includes out of alphabetical order.

Yeah.

> We'll just have to fix it up later,

Sure, I will after release 3.8-rc1.

[...]
>
> I've pushed out the branch with the patch applied (with the above
changed).
>
Thanks for your fix.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.



\
 
 \ /
  Last update: 2012-11-30 13:01    [W:0.924 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site