Messages in this thread Patch in this message |  | | From | Julia Lawall <> | Subject | [PATCH 11/16] drivers/misc/kgdbts.c: use WARN | Date | Sat, 3 Nov 2012 11:58:32 +0100 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Use WARN rather than printk followed by WARN_ON(1), for conciseness.
A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression list es; @@
-printk( +WARN(1, es); -WARN_ON(1); // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/misc/kgdbts.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c index 3aa9a96..8b367db 100644 --- a/drivers/misc/kgdbts.c +++ b/drivers/misc/kgdbts.c @@ -114,9 +114,8 @@ touch_nmi_watchdog(); \ } while (0) #define eprintk(a...) do { \ - printk(KERN_ERR a); \ - WARN_ON(1); \ - } while (0) + WARN(1, KERN_ERR a); \ + } while (0) #define MAX_CONFIG_LEN 40 static struct kgdb_io kgdbts_io_ops;
|  |