lkml.org 
[lkml]   [2012]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH 0/16] use WARN
    Date
    These patches use WARN, which combines printk and WARN_ON(1), or WARN_ONCE,
    which combines printk and WARN_ON_ONCE(1). This does not appear to affect
    the behavior, but makes the code a little more concise.

    The semantic patch that makes this transformation is as follows
    (http://coccinelle.lip6.fr/). In particular, it only transforms the case
    where the WARN_ON or WARN_ON_ONCE is preceded by a single printk.

    // <smpl>
    @bad1@
    position p;
    @@

    printk(...);
    printk@p(...);
    WARN_ON(1);

    @ok1@
    expression list es;
    position p != bad1.p;
    @@

    -printk@p(
    +WARN(1,
    es);
    -WARN_ON(1);

    @@
    expression list ok1.es;
    @@

    if (...)
    - {
    WARN(1,es);
    - }

    @bad2@
    position p;
    @@

    printk(...);
    printk@p(...);
    WARN_ON_ONCE(1);

    @ok2@
    expression list es;
    position p != bad2.p;
    @@

    -printk@p(
    +WARN_ONCE(1,
    es);
    -WARN_ON_ONCE(1);

    @@
    expression list ok2.es;
    @@

    if (...)
    - {
    WARN_ONCE(1,es);
    - }
    // </smpl>



    \
     
     \ /
      Last update: 2012-11-03 12:41    [W:3.241 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site