lkml.org 
[lkml]   [2012]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] atp: remove set_rx_mode_8012()
From
From: Paul Bolle <pebolle@tiscali.nl>
Date: Sat, 03 Nov 2012 10:53:15 +0100

> Building atp.o triggers this GCC warning:
> drivers/net/ethernet/realtek/atp.c: In function ‘set_rx_mode’:
> drivers/net/ethernet/realtek/atp.c:871:26: warning: ‘mc_filter[0]’ may be used uninitialized in this function [-Wuninitialized]
>
> GCC is correct. In promiscuous mode 'mc_filter' will be used
> uninitialized in set_rx_mode_8012(), which is apparently inlined into
> set_rx_mode().
>
> But it turns out set_rx_mode_8012() will never be called, since
> net_local.chip_type will always be RTL8002. So we can just remove
> set_rx_mode_8012() and do some related cleanups.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Applied.
\
 
 \ /
  Last update: 2012-11-03 21:01    [W:0.047 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site