lkml.org 
[lkml]   [2012]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: line6: Fix checkpatch.pl switch - case issue
On Thu, Nov 29, 2012 at 12:21:22PM +0100, Laurent Navet [Mali] wrote:
> From: "Laurent Navet [Mali]" <laurent.navet@gmail.com>
>
> delete old commentted code to avoid this checkpatch error :
> line6/pcm.c:423: ERROR: switch and case should be at the same indent
>
> Signed-off-by: Laurent Navet [Mali] <laurent.navet@gmail.com>

What is the [Mali] thing for?

> ---
> drivers/staging/line6/pcm.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
> index 6c1e313..a0ce781 100644
> --- a/drivers/staging/line6/pcm.c
> +++ b/drivers/staging/line6/pcm.c
> @@ -455,14 +455,6 @@ int line6_init_pcm(struct usb_line6 *line6,
> ep_write = 0x01;
> break;
>
> - /* this is for interface_number == 1:
> - case LINE6_DEVID_TONEPORT_UX2:
> - case LINE6_DEVID_PODSTUDIO_UX2:
> - ep_read = 0x87;
> - ep_write = 0x00;
> - break;
> - */

Why not properly indent it to keep the comment around instead?

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-11-30 04:01    [W:0.032 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site