Messages in this thread | | | Date | Thu, 29 Nov 2012 17:23:16 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 245/270] USB: mct_u232: fix broken close |
| |
On Tue, Nov 27, 2012 at 04:15:51PM +0000, Ben Hutchings wrote: > On Mon, 2012-11-26 at 14:58 -0200, Herton Ronaldo Krzesinski wrote: > > 3.5.7u1 -stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Johan Hovold <jhovold@gmail.com> > > > > commit 5260e458f5eff269a43e4f1e9c47186c57b88ddb upstream. > > > > Make sure generic close is called at close. > > > > The driver relies on the generic write implementation but did not call > > generic close. > > > > Note that the call to kill the read urb is not redundant, as mct_u232 > > uses an interrupt urb from the second port as the read urb and that > > generic close therefore fails to kill it. > > > > Compile-only tested. > > > > Signed-off-by: Johan Hovold <jhovold@gmail.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> > [...] > > This is missing on 3.4; the version I used for 3.2 (attached) should be > applicable.
Thanks, that works.
greg k-h
| |