Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Warn when declaring "struct spinlock foo;" | From | Joe Perches <> | Date | Thu, 29 Nov 2012 13:04:02 -0800 |
| |
spinlock_t should always be used.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e0a674f..f27b0b5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3336,6 +3336,12 @@ sub process { "Avoid line continuations in quoted strings\n" . $herecurr); } +# check for struct spinlock declarations + if ($line =~ /^.\s*\bstruct\s+spinlock\s+\w+\s*;/) { + WARN("USE_SPINLOCK_T", + "struct spinlock should be spinlock_t\n" . $herecurr); + } + # Check for misused memsets if ($^V && $^V ge 5.10.0 && defined $stat &&
| |