Messages in this thread | | | Date | Thu, 29 Nov 2012 10:06:27 -0600 | From | Kent Yoder <> | Subject | Re: [PATCH] char/tpm: Use true and false for bools |
| |
On Thu, Nov 29, 2012 at 01:42:47AM +0100, Peter Huewe wrote: > Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro: > > On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote: > > > - itpm = (probe == 0) ? 0 : 1; > > > + itpm = (probe == 0) ? false : true; > > > > Charming. Not that original had been better, but... > Yeah. Sorry it's late. > The tpm subsection has a lot of nice suprises.
:-) I'd prefer
itpm = !!probe;
Now I don't have to go look up what the possible return values of probe_itpm() are...
Kent
> I changed it to itpm = probe; which is equivalent here and sent out a v2. > I'll probably rewrite that code section anytime soon. > > Thanks for noticing. > Peter >
| |