Messages in this thread | | | Subject | Re: [PATCH] solos-pci: don't call vcc->pop() after pclose() | From | David Woodhouse <> | Date | Thu, 29 Nov 2012 14:42:17 +0000 |
| |
On Thu, 2012-11-29 at 14:20 +0100, Krzysztof Mazur wrote: > if (card->tx_skb[port] == skb) { > skb_get(skb); > solos_pop(SKB_CB(skb)->vcc, skb); > SKB_CB(skb)->vcc = NULL;
Um... yes, that would probably work. But it's subtle enough that it bothers me. And if it *did* cause any strange issues, it's a rare case and would be hard to reproduce/debug. Is it *really* necessary, just to speed up the vcc close? I'm inclined to stick with the 'KISS' approach.
(Note that the card->tx_skb[port] skb isn't on the queue any more; you'd do that bit separately and not in the skb_queue_walk() loop.)
-- dwmw2
[unhandled content-type:application/x-pkcs7-signature] | |