Messages in this thread | | | Date | Thu, 29 Nov 2012 11:21:08 +0200 | Subject | Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99 standard | From | Andy Shevchenko <> |
| |
On Thu, Nov 29, 2012 at 1:56 AM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Wed, 21 Nov 2012 16:31:11 +0200 > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > >> When build a kernel with "make W=1" we will get a warning about missing >> initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't >> initialize the buf[] field of the fifo structure. So, using C99 style helps in >> such case. > > I see no such warning. When fixing warnings or compilation errors, > please always quote the compiler output in the changelog.
Oh, I did wrong assumption. However, it looks like linux-stable 3.0.y is affected;
CC [M] samples/kfifo/inttype-example.o samples/kfifo/inttype-example.c:44:506: warning: missing initializer [-Wmissing-field-initializers] samples/kfifo/inttype-example.c:44:506: warning: (near initialization for ‘(anonymous).buf’) [-Wmissing-field-initializers]
And it seems that my solution not the one which is used in linux-next.
gcc (Debian 4.7.2-2) 4.7.2
-- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |