Messages in this thread | | | Subject | Re: [PATCH] br2684: don't send frames on not-ready vcc | From | David Woodhouse <> | Date | Wed, 28 Nov 2012 09:58:58 +0000 |
| |
On Wed, 2012-11-28 at 09:08 +0100, Krzysztof Mazur wrote: > > I think you might need also an equivalent of > "[PATCH v3 3/7] pppoatm: allow assign only on a connected socket". > > I'm not sure yet. In will test if I can trigger that Oops on pppoatm > without that patch. Testing vcc flags might be sufficient - that's > what I did in the first patch, but you asked what about SOCK_CONNECTED, > and I think it was really needed.
Even if the READY check avoids the oops, I think the patch makes sense. Especially as it makes things consistent with pppoatm. I've applied it to the tree. Thanks.
-- dwmw2
[unhandled content-type:application/x-pkcs7-signature] | |