lkml.org 
[lkml]   [2012]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/25] aio: Refcounting cleanup
Hi Kent,

On Wed, Nov 28, 2012 at 08:43:36AM -0800, Kent Overstreet wrote:
> + * now it's safe to cancel any that need to be.
> + */
> +static void free_ioctx(struct kioctx *ctx)
...
> + aio_nr -= ctx->max_reqs;
> + spin_unlock(&aio_nr_lock);
> +
> + synchronize_rcu();
> +
> + pr_debug("freeing %p\n", ctx);
> + kmem_cache_free(kioctx_cachep, ctx);
> +}

As mentioned on irc, we probably want to avoid the synchronize_rcu()
overhead, since delays here will impact the time it takes for a task to
exit. Cheers,

-ben
--
"Thought is the essence of where you are now."


\
 
 \ /
  Last update: 2012-11-29 02:41    [W:0.139 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site