Messages in this thread | | | Date | Wed, 28 Nov 2012 16:59:06 -0500 | From | chas williams - CONTRACTOR <> | Subject | Re: [PATCH] atm: introduce vcc_pop() |
| |
On Wed, 28 Nov 2012 22:45:34 +0100 Krzysztof Mazur <krzysiek@podlesie.net> wrote:
> On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote: > > i dont like the vcc->pop() implementation and at one point i had the > > crazy idea of using skb->destructors to handle it. however, i think it > > would be necessary to clone the skb's so any existing destructor is > > preserved. > > With this patch we will kill vcc->pop() in drivers and in future > we can do that without changes in drivers.
ok
> > > > > +#define vcc_pop(vcc, skb) vcc_pop_any(vcc, skb) > > > +#define vcc_pop_irq(vcc, skb) vcc_pop_any(vcc, skb) > > > > don't define these if you dont plan on using them anway. > > I removed them. I also added check if vcc is NULL, as David Woodhouse > suggested, some drivers use that.
it should probably be if (likely(vcc) && likely(vcc->pop)) since it will almost always be the case.
| |