lkml.org 
[lkml]   [2012]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] atm: introduce vcc_pop()
On Wed, 28 Nov 2012 22:45:34 +0100
Krzysztof Mazur <krzysiek@podlesie.net> wrote:

> On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote:
> > i dont like the vcc->pop() implementation and at one point i had the
> > crazy idea of using skb->destructors to handle it. however, i think it
> > would be necessary to clone the skb's so any existing destructor is
> > preserved.
>
> With this patch we will kill vcc->pop() in drivers and in future
> we can do that without changes in drivers.

ok

> >
> > > +#define vcc_pop(vcc, skb) vcc_pop_any(vcc, skb)
> > > +#define vcc_pop_irq(vcc, skb) vcc_pop_any(vcc, skb)
> >
> > don't define these if you dont plan on using them anway.
>
> I removed them. I also added check if vcc is NULL, as David Woodhouse
> suggested, some drivers use that.

it should probably be if (likely(vcc) && likely(vcc->pop)) since it
will almost always be the case.


\
 
 \ /
  Last update: 2012-11-29 01:01    [W:0.130 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site