Messages in this thread | | | Date | Wed, 28 Nov 2012 20:04:36 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 31/32] perf, tools: Default to cpu// for events v3 |
| |
> > +static void str_append(char **s, int *len, const char *a) > > +{ > > + int olen = *s ? strlen(*s) : 0; > > + int nlen = olen + strlen(a) + 1; > > + if (*len < nlen) { > > + *len = *len * 2; > > + if (*len < nlen) > > + *len = nlen; > > + *s = realloc(*s, *len); > > + if (!*s) > > + exit(ENOMEM); > > Rather use BUG_ON or event better return -ENOMEM.
Neither makes sense: the callers won't handle it and it's not a bug. If you're out of memory in user space the only thing you can do is to exit.
> > > + if (olen == 0) > > + **s = 0; > > + } > > + strcat(*s, a); > > +} > > Could this one be moved to util/string.c in some generic form?
Ok.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |