Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 28 Nov 2012 08:37:03 -0800 | Subject | Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer |
| |
On Wed, Nov 28, 2012 at 8:22 AM, Kay Sievers <kay@vrfy.org> wrote: > On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk <mtk.manpages@gmail.com> wrote: > >> On a 2.6.31 system, immediately after SYSLOG_ACTION_READ_CLEAR, a >> SYSLOG_ACTION_SIZE_UNREAD returns 0. > > Hmm, sounds like the right thing to do.
Right.
And that's the *OLD* behavior (2.6.31).
>> On 3.5, immediately after SYSLOG_ACTION_READ_CLEAR, the value returned >> by SYSLOG_ACTION_SIZE_UNREAD is unchanged
And this is the *NEW* behavior, and as you say:
> Which sounds at least like weird behaviour, if not "broken".
So the new behavior is insane and different. Let's fix it.
It looks like it is because the new SYSLOG_ACTION_SIZE_UNREAD code does not take the new clear_seq code into account. Hmm?
Linus
| |