lkml.org 
[lkml]   [2012]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: Tree for Nov 26 (staging/fwserial)
From
Date
On Mon, 2012-11-26 at 15:20 -0800, Andrew Morton wrote:
> On Mon, 26 Nov 2012 12:56:07 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > On 11/26/2012 06:17 AM, Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > Changes since 20121115:
> > >
> >
> >
> > on i386:
> >
> > drivers/staging/fwserial/dma_fifo.c: In function 'dma_fifo_in':
> > drivers/staging/fwserial/dma_fifo.c:174:2: error: implicit declaration of function '__WARN_printf'
> >
>
> That should be replaced with WARN(fifo->corrupt, format).

Yeah, not sure what I was thinking there. Or rather not thinking.

> drivers/staging/fwserial/dma_fifo.[ch] appear to be generic code and
> really should be proposed for mm/ or lib/.

If there are other users for which this would be useful, that's ok with
me. I'd feel more comfortable with that after this driver gets some
heavier usage (which shouldn't be a problem once I get a console and
debugger running on top of it).




\
 
 \ /
  Last update: 2012-11-27 09:21    [W:0.108 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site