lkml.org 
[lkml]   [2012]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp
On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote:
> >> +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long cr2)
> >> {
> >> - gpa_t gpa;
> >> + gpa_t gpa = cr2;
> >> pfn_t pfn;
> >>
> >> - if (tdp_enabled)
> >> + if (!ACCESS_ONCE(vcpu->kvm->arch.indirect_shadow_pages))
> >> return false;
> >
> > How is indirect_shadow_pages protected? Why is ACCESS_ONCE() being used
> > to read it?
>
> Hi Marcelo,
>
> It is protected by mmu-lock for it only be changed when mmu-lock is hold. And
> ACCESS_ONCE is used on read path avoiding magic optimization from compiler.

Please switch to mmu_lock protection, there is no reason to have access
to this variable locklessly - not performance critical.

For example, there is no use of barriers when modifying the variable.



\
 
 \ /
  Last update: 2012-11-28 03:21    [W:0.066 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site