Messages in this thread | | | Date | Tue, 27 Nov 2012 21:19:44 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH 02/11] HID: hid-input: simplify hid_input allocation and registration |
| |
On Tue, 27 Nov 2012, Henrik Rydberg wrote:
> > In order to provide fine control for the creation of different > > input devices in probe function of third party drivers, this patch > > split the allocations, the registrations and the free of input > > devices. > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> > > --- > > drivers/hid/hid-input.c | 28 ++++++++++++++++++---------- > > 1 file changed, 18 insertions(+), 10 deletions(-) > > I don't like this patch, nor its purpose. Drivers should not depend on > the hid core working in a particular way internally, that spells > disaster. There must be some other way in which the same effect can be > achieved?
The changelog doesn't seem to be really verbose enough to me.
What exactly is the scenario you are looking at here, Benjamin, please?
Thanks,
-- Jiri Kosina SUSE Labs
| |