Messages in this thread |  | | Date | Tue, 27 Nov 2012 13:53:37 -0600 | From | Mark Langsdorf <> | Subject | Re: [PATCH 4/6 v5] arm highbank: add support for pl320 IPC |
| |
On 11/27/2012 10:12 AM, Thomas Petazzoni wrote: > Dear Mark Langsdorf, > > On Tue, 27 Nov 2012 09:04:32 -0600, Mark Langsdorf wrote: > >> +int ipc_transmit(u32 *data); > > ipc_transmit() looks to me like a way to generic name to be exposed to > the entire kernel.
Good point. Changed to pl320_ipc_transmit()
>> +extern int pl320_ipc_register_notifier(struct notifier_block *nb); >> +extern int pl320_ipc_unregister_notifier(struct notifier_block *nb); > > Why some "extern" here? You don't have these for the other functions in > this header file.
Nice catch. Fixed to export them in cpufreq.
--Mark Langsdorf Calxeda, Inc.
|  |