Messages in this thread | | | Date | Tue, 27 Nov 2012 13:54:34 -0500 | From | chas williams - CONTRACTOR <> | Subject | Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc |
| |
On Tue, 27 Nov 2012 18:02:29 +0000 David Woodhouse <dwmw2@infradead.org> wrote:
> In solos-pci at least, the ops->close() function doesn't flush all > pending skbs for this vcc before returning. So can be a tasklet > somewhere which has loaded the address of the vcc->pop function from one > of them, and is going to call it in some unspecified amount of time. > > Should we make the device's ->close function wait for all TX and RX skbs > for this vcc to complete?
the driver's close routine should wait for any of the pending tx and rx to complete. take a look at the he.c in driver/atm
| |