Messages in this thread | | | Subject | Re: [PATCH 9/9] TTY: call tty_port_destroy in the rest of drivers | From | Peter Hurley <> | Date | Tue, 27 Nov 2012 12:23:59 -0500 |
| |
On Tue, 2012-11-27 at 09:04 -0800, Greg Kroah-Hartman wrote: > On Tue, Nov 27, 2012 at 11:52:09AM -0500, Peter Hurley wrote: > > On Thu, 2012-11-15 at 09:49 +0100, Jiri Slaby wrote: > > > After commit "TTY: move tty buffers to tty_port", the tty buffers are > > > not freed in some drivers. This is because tty_port_destructor is not > > > called whenever a tty_port is freed. This was an assumption I counted > > > with but was unfortunately untrue. So fix the drivers to fulfil this > > > assumption. > > > > > > To be sure, the TTY buffers (and later some stuff) are gone along with > > > the tty_port, we have to call tty_port_destroy at tear-down places. > > > This is mostly where the structure containing a tty_port is freed. > > > This patch does exactly that -- put tty_port_destroy at those places. > > > > > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > > > > Hi Jiri & Greg & Alan, > > > > I'd be more than willing to fixup staging/fwserial against this series > > but I'm unclear on the mechanics since this series isn't in staging-next > > and staging/fwserial isn't in tty-next. > > The series is in tty-next, right?
Yes.
> Make it against linux-next, which has > the trees combined, and I'll work to figure it out when/where to apply > it.
Ok, will do.
Thanks, Peter
| |