Messages in this thread | | | Date | Tue, 27 Nov 2012 10:23:33 -0500 | From | chas williams - CONTRACTOR <> | Subject | Re: [PATCH v3 8/7] pppoatm: fix missing wakeup in pppoatm_send() |
| |
On Tue, 27 Nov 2012 13:27:47 +0000 David Woodhouse <dwmw2@infradead.org> wrote:
> > i really would prefer not to use a strange name since it might confuse > > larger group of people who are more familiar with the traditional meaning > > of this function. vcc_release() isnt exported so we could rename it if > > things get too confusing. > > > > i have to look at this a bit more but we might be able to use release_cb > > to get rid of the null push to detach the underlying protocol. that would > > be somewhat nice. > > In the meantime, should I resend this patch with the name 'release_cb' > instead of 'unlock_cb'? I'll just put a comment in to make sure it isn't > confused with vcc_release(), and if we need to change vcc_release() > later we can. >
yes, but dont call it 8/7 since that doesnt make sense.
| |