lkml.org 
[lkml]   [2012]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 053/270] mmc: sdhci-s3c: fix the wrong number of max bus clocks
    From
    Date
    On Mon, 2012-11-26 at 14:55 -0200, Herton Ronaldo Krzesinski wrote:
    > 3.5.7u1 -stable review patch. If anyone has any objections, please let me know.
    >
    > ------------------
    >
    > From: Jaehoon Chung <jh80.chung@samsung.com>
    >
    > commit 5feb54a1ab91a237e247c013b8c4fb100ea347b1 upstream.
    >
    > We can use up to four bus-clocks; but on module remove, we didn't
    > disable the fourth bus clock.
    >
    > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
    > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
    > Signed-off-by: Chris Ball <cjb@laptop.org>
    > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>

    This is missing from 3.4 and 3.6 (but not 3.2); it apparently needed its
    context adjusted.

    Ben.

    > ---
    > drivers/mmc/host/sdhci-s3c.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
    > index a50c205..02b7a4a 100644
    > --- a/drivers/mmc/host/sdhci-s3c.c
    > +++ b/drivers/mmc/host/sdhci-s3c.c
    > @@ -656,7 +656,7 @@ static int __devexit sdhci_s3c_remove(struct platform_device *pdev)
    >
    > pm_runtime_disable(&pdev->dev);
    >
    > - for (ptr = 0; ptr < 3; ptr++) {
    > + for (ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
    > if (sc->clk_bus[ptr]) {
    > clk_disable(sc->clk_bus[ptr]);
    > clk_put(sc->clk_bus[ptr]);

    --
    Ben Hutchings
    Never attribute to conspiracy what can adequately be explained by stupidity.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-11-27 16:41    [W:4.371 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site