Messages in this thread | | | Date | Tue, 27 Nov 2012 14:16:48 +0530 | Subject | Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver | From | Viresh Kumar <> |
| |
On 27 November 2012 14:10, Lee Jones <lee.jones@linaro.org> wrote: > On Tue, 27 Nov 2012, Viresh Kumar wrote: >> Problem is with invert polarity, which the interrupt controller is not aware of. >> For example, suppose interrupt controller needs Rising edge interrupt, but >> the board has inverted the line between stmpe and IC. So, we will get >> Rising high from the routine you mentioned, but we need to generate >> opposite of that to make it rising high. > > Surely that would be a hardware design error/quirk?
Yes.
> Can you give an example where this has happened?
I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin would have, that's why he added that part of code :)
@Rabin/Linus: Do you remember why have you added this in stmpe driver:
+ if (stmpe->pdata->irq_invert_polarity) + icr ^= STMPE_ICR_LSB_HIGH; +
Does somebody actually need it?
-- viresh
| |