Messages in this thread | | | Date | Mon, 26 Nov 2012 10:59:56 +0100 | From | Sascha Hauer <> | Subject | Re: [PATCH 3/4] imx27-dt: configure i2c1 gpio on armadeus apf27 |
| |
On Mon, Nov 26, 2012 at 10:28:58AM +0100, Thomas Petazzoni wrote: > Dear Philippe Reynes, > > On Sun, 25 Nov 2012 21:17:04 +0100, Philippe Reynes wrote: > > > static const struct of_dev_auxdata imx27_auxdata_lookup[] __initconst = { > > @@ -48,6 +49,10 @@ int apf27_lan8700_wakeup(struct phy_device *phydev) > > static void __init apf27_init(void) > > { > > phy_register_fixup_for_id("imx27-fec.0-1:1f", apf27_lan8700_wakeup); > > + > > + /* configure i2c1 gpio */ > > + mxc_gpio_mode((GPIO_PORTD | GPIO_OUT | GPIO_PF | 17)); > > + mxc_gpio_mode((GPIO_PORTD | GPIO_OUT | GPIO_PF | 18)); > > } > > I haven't followed i.MX 27 support lately, but this surely should be > done using a pinctrl driver. I see that there is a general pinctrl > driver for i.MX, but a drivers/pinctrl/pinctrl-imx27.c might be > missing. It would probably be a better idea to implement the missing > pinctrl driver, if not already available?
It's not available, and yes, it should be implemented. Adding the iomux setup to a i.MX27 SoC specific file is not a good idea.
Sascha
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |