Messages in this thread | | | Date | Mon, 26 Nov 2012 15:59:37 -0600 | Subject | Re: [RFC v2 8/8] drm: tegra: Add gr2d device | From | Rob Clark <> |
| |
On Mon, Nov 26, 2012 at 7:19 AM, Terje Bergstrom <tbergstrom@nvidia.com> wrote: > > +struct tegra_drm_submit_args { > + void *context;
Just a quick comment..
You shouldn't really use ptr here, but instead use a 64bit type so that you don't run into issues later for armv8/64bit. Same comment applies in a few other places too.
I'll try and spend a bit more time going through this in more detail in the coming days
BR, -R
> + __u32 num_syncpt_incrs; > + __u32 num_cmdbufs; > + __u32 num_relocs; > + __u32 submit_version; > + __u32 num_waitchks; > + __u32 waitchk_mask; > + __u32 timeout; > + struct tegra_drm_syncpt_incrs *syncpt_incrs; > + struct tegra_drm_cmdbuf *cmdbufs; > + struct tegra_drm_reloc *relocs; > + struct tegra_drm_waitchk *waitchks; > + > + __u32 pad[5]; /* future expansion */ > + __u32 fence; /* Return value */ > +}; > +
| |