Messages in this thread Patch in this message | | | Date | Mon, 26 Nov 2012 14:23:56 -0600 | From | Kent Yoder <> | Subject | Re: [PATCH] TPM: Switch to __packed instead of __attribute__((packed)) |
| |
On Wed, Nov 21, 2012 at 11:50:24PM +0100, Peter Huewe wrote: > Am Mittwoch, 21. November 2012, 21:56:45 schrieb Jason Gunthorpe: > > This seems to be preferred these days. > > > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > Looks good to me > Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
Applied. I also rolled in an update to tpm_acpi.c to this commit:
diff --git a/drivers/char/tpm/tpm_acpi.c b/drivers/char/tpm/tpm_acpi.c index 56051d0..64420b3 100644 --- a/drivers/char/tpm/tpm_acpi.c +++ b/drivers/char/tpm/tpm_acpi.c @@ -33,13 +33,13 @@ struct acpi_tcpa { u16 platform_class; union { struct client_hdr { - u32 log_max_len __attribute__ ((packed)); - u64 log_start_addr __attribute__ ((packed)); + u32 log_max_len __packed; + u64 log_start_addr __packed; } client; struct server_hdr { u16 reserved; - u64 log_max_len __attribute__ ((packed)); - u64 log_start_addr __attribute__ ((packed)); + u64 log_max_len __packed; + u64 log_start_addr __packed; } server; }; }; Thanks, Kent
> Thanks, > Peter >
| |