lkml.org 
[lkml]   [2012]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled
On 11/13/2012 05:35 AM, Linus Walleij wrote:

> On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix build errors when CONFIG_OF is not enabled by including
>> <linux/of.h> (needs to be added in any case).
>> An alternative fix could be to make the driver depend on OF.
>>
>> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
>> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
>> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Rabin Vincent <rabin.vincent@stericsson.com>
>> Cc: Samuel Ortiz <sameo@linux.intel.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>




ping?

This patch is still needed in linux-next.

---
From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_OF is not enabled by including
<linux/of.h> (needs to be added in any case).
An alternative fix could be to make the driver depend on OF.

drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/mfd/stmpe.c | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20121112.orig/drivers/mfd/stmpe.c
+++ linux-next-20121112/drivers/mfd/stmpe.c
@@ -13,6 +13,7 @@
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
+#include <linux/of.h>
#include <linux/pm.h>
#include <linux/slab.h>
#include <linux/mfd/core.h>

\
 
 \ /
  Last update: 2012-11-26 20:41    [W:0.211 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site