lkml.org 
[lkml]   [2012]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 012/270] netfilter: nf_nat_sip: fix via header translation with multiple parameters
    Date
    3.5.7u1 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Patrick McHardy <kaber@trash.net>

    commit f22eb25cf5b1157b29ef88c793b71972efc47143 upstream.

    Via-headers are parsed beginning at the first character after the Via-address.
    When the address is translated first and its length decreases, the offset to
    start parsing at is incorrect and header parameters might be missed.

    Update the offset after translating the Via-address to fix this.

    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Acked-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    net/ipv4/netfilter/nf_nat_sip.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/net/ipv4/netfilter/nf_nat_sip.c b/net/ipv4/netfilter/nf_nat_sip.c
    index bb71caa..6dbcdb1 100644
    --- a/net/ipv4/netfilter/nf_nat_sip.c
    +++ b/net/ipv4/netfilter/nf_nat_sip.c
    @@ -148,7 +148,7 @@ static unsigned int ip_nat_sip(struct sk_buff *skb, unsigned int dataoff,
    if (ct_sip_parse_header_uri(ct, *dptr, NULL, *datalen,
    hdr, NULL, &matchoff, &matchlen,
    &addr, &port) > 0) {
    - unsigned int matchend, poff, plen, buflen, n;
    + unsigned int olen, matchend, poff, plen, buflen, n;
    char buffer[sizeof("nnn.nnn.nnn.nnn:nnnnn")];

    /* We're only interested in headers related to this
    @@ -163,11 +163,12 @@ static unsigned int ip_nat_sip(struct sk_buff *skb, unsigned int dataoff,
    goto next;
    }

    + olen = *datalen;
    if (!map_addr(skb, dataoff, dptr, datalen, matchoff, matchlen,
    &addr, port))
    return NF_DROP;

    - matchend = matchoff + matchlen;
    + matchend = matchoff + matchlen + *datalen - olen;

    /* The maddr= parameter (RFC 2361) specifies where to send
    * the reply. */
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-11-26 19:01    [W:4.052 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site