lkml.org 
[lkml]   [2012]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 194/270] pinctrl: remove mutex lock in groups show
    Date
    3.5.7u1 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Haojian Zhuang <haojian.zhuang@gmail.com>

    commit 7ae9d71e8df27a3ab60a05ae3add08728debc09c upstream.

    Mutex is locked duplicatly by pinconf_groups_show() and
    pin_config_group_get(). It results dead lock. So avoid to lock mutex
    in pinconf_groups_show().

    Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/pinctrl/pinconf.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
    index 43f474c..baee2cc 100644
    --- a/drivers/pinctrl/pinconf.c
    +++ b/drivers/pinctrl/pinconf.c
    @@ -537,8 +537,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
    seq_puts(s, "Pin config settings per pin group\n");
    seq_puts(s, "Format: group (name): configs\n");

    - mutex_lock(&pinctrl_mutex);
    -
    while (selector < ngroups) {
    const char *gname = pctlops->get_group_name(pctldev, selector);

    @@ -549,8 +547,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
    selector++;
    }

    - mutex_unlock(&pinctrl_mutex);
    -
    return 0;
    }

    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-11-26 19:01    [W:4.068 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site