lkml.org 
[lkml]   [2012]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 016/270] netfilter: nfnetlink_log: fix NLA_PUT macro removal bug
    Date
    3.5.7u1 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Patrick McHardy <kaber@trash.net>

    commit 2dba62c30ec3040ef1b647a8976fd7e6854cc7a7 upstream.

    Commit 1db20a52 (nfnetlink_log: Stop using NLA_PUT*().) incorrectly
    converted a NLA_PUT_BE16 macro to nla_put_be32() in nfnetlink_log:

    - NLA_PUT_BE16(inst->skb, NFULA_HWTYPE, htons(skb->dev->type));
    + if (nla_put_be32(inst->skb, NFULA_HWTYPE, htons(skb->dev->type))

    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Acked-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    net/netfilter/nfnetlink_log.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
    index 3c3cfc0..bbc1d91 100644
    --- a/net/netfilter/nfnetlink_log.c
    +++ b/net/netfilter/nfnetlink_log.c
    @@ -476,7 +476,7 @@ __build_packet_message(struct nfulnl_instance *inst,
    }

    if (indev && skb_mac_header_was_set(skb)) {
    - if (nla_put_be32(inst->skb, NFULA_HWTYPE, htons(skb->dev->type)) ||
    + if (nla_put_be16(inst->skb, NFULA_HWTYPE, htons(skb->dev->type)) ||
    nla_put_be16(inst->skb, NFULA_HWLEN,
    htons(skb->dev->hard_header_len)) ||
    nla_put(inst->skb, NFULA_HWHEADER, skb->dev->hard_header_len,
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-11-26 19:01    [W:5.241 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site