lkml.org 
[lkml]   [2012]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1 1/3] mfd: stmpe: Arrange #include <header files> in alphabetical order
On Mon, Nov 26, 2012 at 03:31:45PM +0000, Lee Jones wrote:
> On Mon, 26 Nov 2012, Viresh Kumar wrote:
>
> > On 26 November 2012 18:55, Lee Jones <lee.jones@linaro.org> wrote:
> >
> > > Why do you need to sort them? Is there _really_ a need?
> >
> > Many people & maintainers like to have their header files ordered. The
> > reason for that is:
> >
> > If they are not ordered, there is a possibility of adding an header file
> > multiple times in a file. This might not do something serious
> > when thinking about compilation time or Image size, but adding an header
> > file multiple times is simply wrong.
> >
> > This can't be caught in patch reviews most of the time, as diff may not show
> > the earlier inclusion.
> >
> > That's why i ordered them. And i don't see any harm in doing so.
>
> I don't see any harm in it, but it's pretty pointless.
>
> There aren't many maintainers who insist on such things,
And I'm not one of those.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2012-11-26 17:41    [W:0.056 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site