lkml.org 
[lkml]   [2012]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: hidraw: fix nonblock read return EAGAIN after device removed
On Mon, 26 Nov 2012, Dmitry Torokhov wrote:

> > Hi Linux-Input, Jiri, Dmitry,
> > this patch is related to nonblock read on hidraw device.
> > when nonblock read the condition check (file->f_flags & O_NONBLOCK)
> > always be true,
> > signal_pending and device exist checking never get a chance to run, so
> > the user mode code always
> > get EAGAIN even if device removed. move nonblock mode checking to the
> > last can fix this problem.
> >
> > Signed-off-by: Founder Fang <founder.fang@gmail.com>
> >
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Makes sense to me. However it looks like your mailer line-wrapped the
> patch, please resend so Jiri can apply it.

For some reason, the patch has been sent to me twice, once it has been
fine and the second time it has been line wrapped.

I have now applied the non-broken version. Thanks,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2012-11-26 16:01    [W:0.044 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site